Fog Creek Software
Discussion Board




Joel, please fix this...

Hi Joel,

Following on from:

http://discuss.fogcreek.com/joelonsoftware/default.asp?cmd=show&ixPost=138553&ixReplies=3

I noticed that this post:

http://discuss.fogcreek.com/joelonsoftware/default.asp?cmd=show&ixPost=140445&ixReplies=4

generates 8 (eight) script errors when you load it (Unterminated string constant errors).

It looks like your link decorating script is failing pretty badly when there are quote characters involved.

I trust that you will not think this too trivial for your attention.

Steve Jones (UK).

Steve Jones (UK)
Wednesday, May 12, 2004

I think its fine in Firefox, reallocating as IE bug...

Ok, it warrants a :-}

Simon Lucy
Wednesday, May 12, 2004

It's not an IE bug, it is a bug in the Javascript that the forum generates when it decorates the links to hide Joel's redirector. Do a view source and its obvious.

If you don't get the error messages in firefox that is probably because they are supressed, not because they're not there. Unless firefox is more forgiving of scripting errors than IE, I wouldn't know as I only use IE.

Steve Jones (UK)
Wednesday, May 12, 2004

In the Comments page, which is the only way to add a comment is the instruction

"Do not use HTML tags. Surround URLs with spaces."

If you put ' http://www.joelonsoftware.com ' does it still fail?

Simon Lucy
Wednesday, May 12, 2004

Sense of proportion error: please remove pole from appropriate orifice and reboot.

Kidder
Wednesday, May 12, 2004

The error is there with Firefox, but it doesn't show Javascript errors to users on the assumption that users are not interested in them, and not qualified to do anything about them.

If you want to see errors when browsing with Firefox, open the Javascript Console.

Oh, and I agree: pole, rectum, remove, reboot. :)

Brad Wilson (dotnetguy.techieswithcats.com)
Wednesday, May 12, 2004

>>"it doesn't show Javascript errors to users on the assumption that users are not interested in them, and not qualified to do anything about them."

Exactly how it should be.  If a web page is poorly coded, there's nothing I can do about it, so why bombard me with error messages.

Other software would do well to learn this lesson.

My Cousin Vinniwashtharam
Wednesday, May 12, 2004

You can turn off Javascript errors in IE too, but some of us have it turned on because we need to be prompted when we are debugging our own Javascript and it is annoying to turn on and off. 

Phibian
Wednesday, May 12, 2004

It also looks like the descender of the 'g' in 'fog creek' is not hyperlinked to anything.  While you're in there...

;-)

bob
Wednesday, May 12, 2004

Golly bob, you're right. That Joel character *still* hasn't fixed that. Anyone would think he's trying to avoid doing anything about it.

Steve Jones (UK)
Wednesday, May 12, 2004

If Microsoft can't fix a script error on line 4 of the Hotmail log in page, then why do you expect Joel to do anything about his links?

Stephen Jones
Wednesday, May 12, 2004

Steve, you're trying to pick a fight with Joel aren't you?

RP
Wednesday, May 12, 2004

RP, no there ain't no contest, I wouldn't want to waste both our time.

We're both very confident in what we do, which is good, it just happens that we have different ideas about what is correct. No problem.

It's just that, from my perspective, it seems somewhat hypocritical to write about hiring the best and all these wonderful ideas about doing such a bang up job, then making silly mistakes and trying to palm it off by suggesting that its beneath him to address such trivial things. Why not just accept that you're not perfect, fix the bug and get on with your life ?

My assertion is that people do notice, if only on a sub-conscious level and the Users can tell the difference between a piece of software that is barely adequate and another one that is finished to the best of the developer's ability. Let's face it, it isn't like Joel/Fog Creak have such a massive portfolio of products that they can't assign an hour a month to address these minor niggles.

As I said above, it is just a different approach. Joel thinks I'm a perfectionist, but I would say that he says that as a defense mechanism, based upon his insecurity. I bet that in his heart, he knows I'm right, it just annoys him that someone would point it out on his own forum.

As an aside, I'd like to mention that I do have a lot of respect for Joel, its just that sometimes he can be a bit of a spoilt child (e.g. deleting threads that question his way of doing things). End of aside.

Steve Jones (UK)
Thursday, May 13, 2004

Steve, I think you and Joel need to kiss and make up. How 'bout it, gents? For the children. Yes, for the children.

Senor Loco
Thursday, May 13, 2004

*  Recent Topics

*  Fog Creek Home